Fix crossing rail not working with experimental minecart improvements#21
Open
mbmikaelyan wants to merge 2 commits intoFXCourel:1.21.11from
Open
Fix crossing rail not working with experimental minecart improvements#21mbmikaelyan wants to merge 2 commits intoFXCourel:1.21.11from
mbmikaelyan wants to merge 2 commits intoFXCourel:1.21.11from
Conversation
NewMinecartBehaviorMixin was missing the getRailShape() logic that OldMinecartBehaviorMixin had, so crossing direction switching was never applied when experimental minecarts were enabled. Also updates isPoweringRail signatures to match the changed BlockState.is(Object) signature in 26.1.
Replaced two ordinal-based redirects with a single redirect that intercepts all getValue calls in moveAlongTrack and uses a type check to only apply the crossing rail shape fix when the property is a RailShape. This avoids fragile ordinal counting and correctly handles the mixed Boolean/RailShape getValue calls in the method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewMinecartBehaviorMixin was missing the getRailShape() logic that OldMinecartBehaviorMixin had, so crossing direction switching was never applied when experimental minecarts were enabled.
Also updates isPoweringRail signatures to match the changed BlockState.is(Object) signature in 26.1.
I used Claude.Ai for this